search

zxing-js / library

Multi-format 1D/2D barcode image processing library, usable in JavaScript ecosystem.
https://zxing-js.github.io/library/
Apache License 2.0
2.36k stars 535 forks source link

Status of RSS-14 and RSS-Expanded readers #80

Open aryahz opened 5 years ago

aryahz commented 5 years ago

What's the status of the RSS-14 and RSS-Expanded readers - are the readers going to be available soon?

odahcam commented 5 years ago

We have nothing scheduled for them yet. 😢

I'm currently working on the library quality itself and accepting and giving support to ports from the original repo, so if someone make a PR with RSS-14 and RSS-Expanded readers certainty they gonna be available ASAP.

That's all for now, thanks for reaching out. Feel free to ask more questions.

aryahz commented 5 years ago

Thanks for the update. We really like what you've done so far with the library and are considering porting the RSS-14 and RSS-Expanded readers ourselves, as we need the functionality fairly soon. If we decide to go ahead I will make a PR.

odahcam commented 5 years ago

That's great! If you do so, please join our Gitter channel for better support. 🙂

werthdavid commented 5 years ago

@aryahz any decisions made yet?

aryahz commented 5 years ago

Yes, we've converted the RSS-14 reader classes and they're working in our test environment. See https://github.com/zxing-js/library/pull/114 for details.

ilinkMat commented 5 years ago

I tried Porting the RSS Expanded readers but I'm running in to some issues when importing the library on to a angular project. Could any one help me out here ? Please

The command used to build the ported files is yarn clean && yarn tsc && yarn webpack --mode production

Once the build process was successful , I copied the files from the folders 'esm5' & 'umd' added to the node-modules of the angular project and I see the below errors on the console log

image

odahcam commented 5 years ago

This way of installation is not recomended, please take a look on https://stackoverflow.com/questions/8088795/installing-a-local-module-using-npm

Also we have a project in Angular running a scanner built with this library: https://github.com/zxing-js/ngx-scanner

ilinkMat commented 5 years ago

Thank you for you support. I did try the installation method which you suggested as well . I wasn't able to proceed further.

I suspect that the code which I have written to Port RSS Expanded Reader has circular dependencies in it which is why I see the errors.

https://res.cloudinary.com/dzu1mlynh/image/upload/v1544602104/Screen_Shot_2018-12-12_at_1.24.18_PM.png

https://res.cloudinary.com/dzu1mlynh/image/upload/v1544602085/Zxing-1.png

odahcam commented 5 years ago

You seem right, you can open a [WIP] PR here so we can analyse the code together if you want, also our build system will automatically run on Travis every push you make.

ilinkMat commented 5 years ago

@odahcam I have created a pull request as requested . #120.

github-actions[bot] commented 4 years ago

Stale issue message