dude

[bvalosek]

tests plz

would be perfect since its a parser with a basic input -> output use case

[zxqx]

good call - making it happen

[bvalosek]

Current tests are a good start, they effectively assert that parsing a date gives us "some" numbers back and doesn't error out. You could basically roll those all up into one suite (one test( ... ) call), that is just a sanity check to makes sure all the methods return numbers.

Something to keep in mind:

• All tests should be completely independent. Aside from side-effect-free helper functions, all objects/vars should be fresh / new inside each test( ... ) block
• Test for exact outputs. Try a few different inputs that test different code paths / are weird. e.g. make sure it handles stuff like < 10 numbers ("01") vs >= 10 numbers ("10") (for example)
• Most of your tests will look like t.strictEqual(new ICalDateParser(input).parse().getMinutes(), 34, 'desc');

[bvalosek]

Also dont forget to test for bad inputs. Whether you throw (and what type of error is thrown), or return undefined or null or whatever is up to you but make sure its defined and tested.

• Isolated tests, distinct input condition testing, and bad input response checking: https://github.com/bvalosek/iterable/blob/master/test/range.js #solly

[zxqx]

Good shit man, updated tests here: https://github.com/zakangelle/ical-date-parser/tree/master/test