setupCDC.sh and tpm should have consistent names for CDC type

zxs / tungsten-replicator

Automatically exported from code.google.com/p/tungsten-replicator

0 stars 0 forks source link

setupCDC.sh and tpm should have consistent names for CDC type #1021

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?

1. Configure Oracle to MySQL.
2. Use --svc-table-engine=CDCASYNC
3. Use HOTLOG_SOURCE in setupCDC.conf

What is the expected output?

Installation succeeds.

What do you see instead?

ERROR >> > Message: Value must be CDC, CDCSYNC

What is the possible cause?

--svc-table-engine validation has been made more strict.

What is the proposed solution?

1. Allow backward compatibility.

2. Additionally, make tpm and setupCDC.conf values consistent:

In tpm: CDC/CDCASYNC or CDCSYNC
In setupCDC.conf: CDC/CDCASYNC/HOTLOG_SOURCE or CDCSYNC/SYNC_SOURCE
In the docs: recommend CDCASYNC or CDCSYNC in both tpm and setupCDC.conf. 
Forget other variants, though
in the code we'll have it background compatible to not break customers/users.

Additional information

Eric H. will fix tpm.
I'll take setupCDC.sh part.

Original issue reported on code.google.com by linas.vi...@continuent.com on 29 Sep 2014 at 3:23

Blocked on: #1014

GoogleCodeExporter commented 9 years ago

Original comment by linas.vi...@continuent.com on 29 Sep 2014 at 3:23

Added labels: Regression

GoogleCodeExporter commented 9 years ago

[deleted comment]

GoogleCodeExporter commented 9 years ago

This issue was updated by revision r2605.

Added option for Oracle --svc-table-engine type CDCASYNC

Original comment by eric.har...@continuent.com on 29 Sep 2014 at 4:53

GoogleCodeExporter commented 9 years ago

This issue was updated by revision r2608.

Tester: Stephane

Support for CDCASYNC (previously HOTLOG_SOURCE) and CDCSYNC (previously 
SYNC_SOURCE) option names for cdc_type. Backward compatibility preserved. New 
users shall be adviced to use the new names, which are consistent with tpm ones.

Original comment by linas.vi...@continuent.com on 30 Sep 2014 at 10:50

Changed state: QA

GoogleCodeExporter commented 9 years ago

Hi Stephane,

I believe you're the best person to do a quick double check on this one.

Original comment by linas.vi...@continuent.com on 30 Sep 2014 at 10:54

Added labels: Tester-Stephane

GoogleCodeExporter commented 9 years ago

These changes have been documented in the corresponding 2.1/2.2/3.0 docs.

Original comment by mc.br...@continuent.com on 6 Oct 2014 at 1:42

GoogleCodeExporter commented 9 years ago

Assigning to Eric H. for QAing.

Original comment by linas.vi...@continuent.com on 8 Oct 2014 at 8:45

Added labels: Tester-EricH
Removed labels: Tester-Stephane

GoogleCodeExporter commented 9 years ago

Used CDCSYNC and CDCASYNC in setupCDC and it works as expected.

Original comment by eric.har...@continuent.com on 8 Oct 2014 at 9:37

Changed state: Fixed