search

zxvnme / zgui

zxvnme's graphical user interface
MIT License
399 stars 53 forks source link

Make indentation consistent #59

Closed danielkrupinski closed 5 years ago

zxvnme commented 5 years ago

Code was formatted by IDE during commiting changes to repository via JetBrains VCS.

danielkrupinski commented 5 years ago

Reference

48cf commented 5 years ago
  1. The code was initially yours, doesn't matter though, but you could've formatted it when pushing.
  2. The code style is a personal preference, it is not written anywhere that all code written in Python has to follow these guidelines (on the reference you linked its even stated: PEP8 recommends that Python code indentation be a multiple of four.).
danielkrupinski commented 5 years ago

My initial code has consistent 4 space indentation- https://gist.github.com/danielkrupinski/02ffcbd7a2bc45eeb8ef648f8a80768c @zxvnme should keep indentation style as well as quotes style consistent

48cf commented 5 years ago

My initial code has consistent 4 space indentation - https://gist.github.com/danielkrupinski/02ffcbd7a2bc45eeb8ef648f8a80768c

Okay, my bad, the code was re-formatted while pushing to the repository thanks to Jetbrains IDE, what's your thoughts on the 2nd point though?

danielkrupinski commented 5 years ago

PEP8 style guide are widely accepted by Python programmers and 4 space indentation is nearly standard indentation for Python scripts. Nonetheless it's up to you to write consequent code following good practices.