zyachel / libremdb

A free & open source IMDb front-end.
https://libremdb.iket.me
GNU Affero General Public License v3.0
303 stars 30 forks source link

PNPM Version / Lockfile Mismatch #42

Closed twomoses closed 1 year ago

twomoses commented 1 year ago
Step 5/23 : RUN pnpm install --frozen-lockfile

 ---> Running in 3f9499b65abe

 ERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE  Cannot perform a frozen installation because the version of the lockfile is incompatible with this version of pnpm

Try either:
1. Aligning the version of pnpm that generated the lockfile with the version that installs from it, or
2. Migrating the lockfile so that it is compatible with the newer version of pnpm, or
3. Using "pnpm install --no-frozen-lockfile".
Note that in CI environments, this setting is enabled by default.

ERROR: Build step failed with exception
com.github.dockerjava.api.exception.DockerClientException: Could not build image: The command '/bin/sh -c pnpm install --frozen-lockfile' returned a non-zero code: 1
    at com.github.dockerjava.api.command.BuildImageResultCallback.getImageId(BuildImageResultCallback.java:78)
    at com.github.dockerjava.api.command.BuildImageResultCallback.awaitImageId(BuildImageResultCallback.java:50)
    at com.nirima.jenkins.plugins.docker.builder.DockerBuilderPublisher$Run.buildImage(DockerBuilderPublisher.java:404)
    at com.nirima.jenkins.plugins.docker.builder.DockerBuilderPublisher$Run.run(DockerBuilderPublisher.java:344)
    at com.nirima.jenkins.plugins.docker.builder.DockerBuilderPublisher.perform(DockerBuilderPublisher.java:486)
    at jenkins.tasks.SimpleBuildStep.perform(SimpleBuildStep.java:123)
    at hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:80)
    at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
    at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:818)
    at hudson.model.Build$BuildExecution.build(Build.java:199)
    at hudson.model.Build$BuildExecution.doRun(Build.java:164)
    at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:526)
    at hudson.model.Run.execute(Run.java:1900)
    at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:44)
    at hudson.model.ResourceController.execute(ResourceController.java:101)
    at hudson.model.Executor.run(Executor.java:442)
Build step 'Build / Publish Docker Image' marked build as failure

According to this comment from a maintainer of PNPM, the version should be pinned in CI pipelines.

twomoses commented 1 year ago

I changed --frozen-lockfile to --no-frozen-lockfile on my local, and it appears to be running properly. That may not be the proper fix, and I have not verified that everything functions, only that it runs and basics are working.

zyachel commented 1 year ago

ah, I see I accidentally committed this ioredis update while generating CHANGELOG.md and bumping version:

https://github.com/zyachel/libremdb/commit/86737c51eec23bb00990be841dde4262f39519ca#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L22-R22

let me just bump all dependencies :)

twomoses commented 1 year ago

Looks great! Feel free to add me to the list:

https://libremdb.nerdyfam.tech/ Location: U.S. Operated by: Nerdyfam.tech