zyachel / quetre

A libre front-end for Quora
https://quetre.iket.me
GNU Affero General Public License v3.0
418 stars 28 forks source link

Markup differences #1

Closed zedeus closed 2 years ago

zedeus commented 2 years ago

Wonderful project! I noticed the formatting/markup is lacking a little bit.

Example 1: https://quetre.herokuapp.com/How-does-Melatonin-work-on-the-brain/

The way Quetre displays it is much more condensed, which imo lowers readability a lot. It's harder to distinguish sections and paragraphs. Not sure if this was done on purpose, but I'd suggest leaning a little closer to the way Quora renders it.

Quora image

Quetre image

Example 2: https://quetre.herokuapp.com/What-Skyrim-race-is-the-most-Croatian/

Missing formatting.

Quora image

Quetre image

zyachel commented 2 years ago

Yes, the bottom padding on Quora for paragraphs is 1em. Here I was intentionally being conservative. Nonetheless, I'll change it to 1em.

As for the missing formatting, I'll look into that this weekend.

PS: thanks! The project is heavily inspired by your nitter and orenom's teddit.

zyachel commented 2 years ago

is is alright now, @zedeus?

the padding: issue__padding

and the formatting issue__formatting

zedeus commented 2 years ago

That's great! A minor change that would be nice is for the ordered lists to have 0.7em vertical spacing instead of 1em, right now it's a bit too much (example below). Also, bold text doesn't work for me on Chrome unless the font-weight is increased from 550 to 600.

image

zyachel commented 2 years ago

good catch! I almost forgot that chromium-based browsers are what most people use :p

changed the weight to 600 and reduced the padding for unordered list items.
issue__unordered-list

zedeus commented 2 years ago

Nice! One last thing, the line-height is a bit high at 1.5, whereas Quora uses 1.4. I don't have a specific preference and this doesn't matter that much, just noticed there was extra spacing when comparing the two.

zyachel commented 2 years ago

yeah, earlier i had set the line-height in paragraphs to 1.3, but disabled it as it looked cramped. 1.4 looks reasonable enough. I've made the change.

zedeus commented 2 years ago

Sweet, looks great now!