search

zyachel / quetre

A libre front-end for Quora
https://quetre.iket.me
GNU Affero General Public License v3.0
417 stars 28 forks source link

Mark unanswered (related) questions #69

Closed thecashewtrader closed 1 year ago

thecashewtrader commented 1 year ago

closes #54.

Note: I'm not sure about the need of +spansChecker, but someone else can comment better on that.

zyachel commented 1 year ago

some questions contain tex that needs to be worked on before being picked up by MathJax. that's why there's +spansChecker for them.

thecashewtrader commented 1 year ago

Could you give me an example so I can work on a better implementation?

zyachel commented 1 year ago

this has some good examples: http://localhost:3000/How-do-you-compute-the-Fourier-transform-for-exp-alpha-t-2

ghost commented 1 year ago

@thecashewtrader Hi, thanks for your contribution.

If you could edit your message to use the GitHub tags "closes", "resolves" or "fixes" #54 that would be awesome. Also, I think that making the text gold or a different color would be beneficial.

thecashewtrader commented 1 year ago

@uranuspucksaxophone Oh sorry, I didn't know about the gh tags. I've edited my PR description and proposed a newer change.

ghost commented 1 year ago

@thecashewtrader This nice PR seems to work when rebased on current main, I really can't review the code but since it doesn't seem a big change, I could merge it.

The only issue are the commits names, it should follow the standard written on CONTRIBUTING.md file, you could push the changes to another branch, squash into one commit and make another PR.

thecashewtrader commented 1 year ago

@NebulaOnion #92 should work hopefully!