search

zyang-ur / ReSC

Improving One-stage Visual Grounding by Recursive Sub-query Construction, ECCV 2020
MIT License
81 stars 16 forks source link

mistake in train.py for anchor settings #5

Closed nku-shengzheliu closed 3 years ago

nku-shengzheliu commented 3 years ago

Hi zhengyuan! At line 107 of the train.py file, it should be 'referit' and not 'refeit'. I found this problem when loading the ReSC_base_referit.tar model file you provided to run on the test set. The test set performance was 35% when I used anchor set:

if args.dataset=='refeit':
        anchors = '30,36,  78,46,  48,86,  149,79,  82,148,  331,93,  156,207,  381,163,  329,285'

and reached the performance reported in the paper when I used anchor set:

else:
        anchors = '10,13,  16,30,  33,23,  30,61,  62,45,  59,119,  116,90,  156,198,  373,326'
zyang-ur commented 3 years ago

Hi @nku-shengzheliu,

Thank you so much for catching this!

I'll remove the referit-specific anchor, and add a comment to point to this issue for reference.

Thank you :)