search

zyantific / zydis-rs

Zydis Rust Bindings
MIT License
83 stars 14 forks source link

InstructionAttribute IS_PRIVILIGED is misspelled ("privileged") #15

Closed williballenthin closed 5 years ago

williballenthin commented 5 years ago

The InstructionAttributes bitflag constant IS_PRIVILIGED is misspelled; it should be IS_PRIVILIGED: https://github.com/zyantific/zydis-rs/blob/1a778406758cbbac5a9f9df834add3f509add006/src/enums/mod.rs#L750

In the C source, the documentation is misspelled, but the symbol name is correctly spelled: https://github.com/zyantific/zydis/blob/356e0e60c1e7e3c9a7002e3ea9b9c6e95de9ca8c/include/Zydis/DecoderTypes.h#L265

image

th0rex commented 5 years ago

Thanks again, I fixed this in https://github.com/zyantific/zydis-rs/commit/e8338680cacaed391a800298a11e0d3b4b600e1e. I also forwarded this so the doc comment gets fixed.