search

zyantific / zydis

Fast and lightweight x86/x86-64 disassembler and code generation library
https://zydis.re
MIT License
3.47k stars 436 forks source link

Add ZYDIS_BUILD_TESTS option and include tests in CMakeLists.txt #437

Closed topazus closed 1 year ago

athre0z commented 1 year ago

Thanks, that's good to have! I added two more commits to also rework our convenience Makefile and the CI to go via the CMake testing path for the sake of de-duplication.

Edit: Ah, there appear to be issues on Windows.. let me see if I can find out what's the issue there.

athre0z commented 1 year ago

Ok, it's also working on Windows now. I had to replace the literal python3 with the variable populated by find_package(Python ...), add generator expressions for the executable paths (on Windows the executables are placed into sub-directories of the output directory) and add if (TARGET xyz) guards to make sure it doesn't break when e.g. the encoder is disabled.

topazus commented 1 year ago

Thanks for the review and further improvement.