search

zyantific / zydis

Fast and lightweight x86/x86-64 disassembler and code generation library
https://zydis.re
MIT License
3.3k stars 427 forks source link

Fix issue with `llvm-rc` when `ZYDIS_BUILD_SHARED_LIB` is enabled #500

Closed netadr closed 3 months ago

netadr commented 3 months ago

In addition to the changes mentioned in zyantific/zycore-c#70, this changes the encoding of resources/VersionInfo.rc from UTF-16LE to UTF-8 as clang's preprocessor does not support UTF-16.

netadr commented 3 months ago

Shouldn't we replace the copyright sign here as well?

I changed it already here as well.

Sorry, GitHub doesn't do a great job of showing this due to the encoding change, maybe I should have clarified!

flobernd commented 3 months ago

@netadr Oh, my bad. I even clicked on "view file", but GitHub seems to show me the old version.

Do you want to update the zycore-c submodule in this PR? We can do this in a later step as well, if that's more comfortable for you.

netadr commented 3 months ago

Do you want to update the zycore-c submodule in this PR? We can do this in a later step as well, if that's more comfortable for you.

@flobernd Should be fixed now!