zyborg / dotnet-tests-report

GitHub Action to run .NET Core tests and generate report attached to Workflow Run
MIT License
112 stars 36 forks source link

On Windows, resolving temp directory path incorrectly, doubling the path #11

Closed godefroi closed 3 years ago

godefroi commented 3 years ago

I'm seeing this error in each of my calls to this task:

Run zyborg/dotnet-tests-report@v1.3.0
"C:\Program Files\PowerShell\7\pwsh.exe" -f D:\a\_actions\zyborg\dotnet-tests-report\v1.3.0/action.ps1
New-Item: D:\a\_actions\zyborg\dotnet-tests-report\v1.3.0\action.ps1:40
Line |
  40 |  New-Item -Name $tmpDir -ItemType "directory" -Force
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | The filename, directory name, or volume label syntax is incorrect. :
     | 'D:\a\myrepo\myrepo\D:\a\myrepo\myrepo'
ebekker commented 3 years ago

Hmm, interesting, seems to be a problem resolving the full path on Windows, I don't think I've tested this action out on Windows yet, I'll need to make adjustments.

godefroi commented 3 years ago

The action still works, but that error shows up every time it runs.

ebekker commented 3 years ago

Actually, I forgot that I am testing on Windows as well and I didn't run into this issue.

Can you point me to a public example you ran that exhibits this error?

McManning commented 3 years ago

I've been playing around with this action myself and have ran into the same issue.

Here's a public test run from today: https://github.com/McManning/tmp-release-ci/pull/3/checks?check_run_id=2300136665#step:7:11

ebekker commented 3 years ago

I'm not really sure the root cause of this issue, but I've changed the code to try to compute the temp dir using an alternate approach -- if you guys can retry with the latest release and let me know if it fixes it.

ebekker commented 3 years ago

I think the latest point release finally addresses the issue.

McManning commented 3 years ago

I think the latest point release finally addresses the issue.

I've re-ran my tests and can confirm. Thanks!

ebekker commented 3 years ago

Was still not quite right as per #24.