Closed rocklan closed 3 years ago
Thanks :) I'm confused though, it says you approved the changes but then requested more changes an hour later, but I can't seem to find the requested changes.
This PR looks to fix some issues I have experienced. Looking forward to it being merged.
Tx for the contribution @rocklan cc: @Patreos98 @elsleepymena137
This PR looks to fix some issues I have experienced. Looking forward to it being merged.
Not sure why it hasn't been, but in the short term you can link to my commit and use the new features that I added.
@rocklan thanks for adding these 🍺
I can say that your branch works for my scenario here
Great additions, thank you!
This PR adds support for being able to supply extra parameters to
Dotnet test
like--filter category=fast
or--no-build
, this addresses #10. It also adds support for being able to fail the build if the tests fail, which is helpful because currently if any tests fail there's no way to tell from the pull request.Two new parameters have been introduced:
fail_build_on_failed_tests
- boolean, set totrue
to fail the build if any tests fail. The report is still generatedextra_test_parameters
- string, useful for adding extra parameters to dotnet test. Eg,--collect:"XPlat Code Coverage"
These can be used like so:
These changes are backwards compatible, if the parameters aren't supplied things should (ha) continue to work as before.
I am by means a powershell/github actions guru so please double check my changes! They seemed to work ok for me :)