zyborg / dotnet-tests-report

GitHub Action to run .NET Core tests and generate report attached to Workflow Run
MIT License
112 stars 36 forks source link

Error from `mkdir` when running on Ubuntu build agents #24

Closed flcdrg closed 3 years ago

flcdrg commented 3 years ago

The mkdir line is failing when running on Ubuntu agents because while on Windows, mkdir is a PowerShell alias to New-Item, on Linux it is not aliased and instead runs the native mkdir command.

eg.

image

flcdrg commented 3 years ago

I wondered why this didn't have any side effects... until today I tried to use test_results_path and everything is falling in a heap because the _TMP directory doesn't exist

ebekker commented 3 years ago

This is correct, the fix I made for this issue a little while back depends on this behavior (mkdir alias on Windows and native on Linux). With that change, the path error went away on Windows.

flcdrg commented 3 years ago

But with the current code, the action doesn't work if you pass in the test_results_path property, because that code path relies on that temporary directory existing

flcdrg commented 3 years ago

Here's what happens when you try and use test_results_path... image