Update the status check to success if all tests pass

zyborg / dotnet-tests-report

GitHub Action to run .NET Core tests and generate report attached to Workflow Run

MIT License

112 stars 36 forks source link

Update the status check to success if all tests pass #4

Closed NasAmin closed 3 years ago

NasAmin commented 3 years ago

If all tests pass i.e. ResultSummary_outcome is set to Completed then update the check status to success

NasAmin commented 3 years ago

@ebekker Please review. This is to help with getting a green tick on pull requests when all tests pass

NasAmin commented 3 years ago

Related to #1

NasAmin commented 3 years ago

@ebekker I would really appreciate if you can give this PR a review.

ebekker commented 3 years ago

Hmm, unfortunately this is a breaking change because it changes the name of the input parameter that was introduced in the previous release. Normally, I would be hesitant to accept this without some mitigation (i.e. accepting the old param name and converting it to the new value), but since this hasn't been released that long, and pby not too much usage, I'll go ahead.

The change looks great otherwise, thanks!

NasAmin commented 3 years ago

@ebekker Thanks very much and a good point on backwards compatibility.