search

zydezu / ModernX

My fork of modernX (a replacement for MPV that retains the functionality of the default OSC), adding additional features - see builds at: https://github.com/zydezu/mpvconfig
131 stars 5 forks source link

Seekbar chapter title tooltips are slightly out of sync with the actual chapter times #22

Closed 0xMOPI closed 4 months ago

0xMOPI commented 5 months ago

The seekbar markers are in the correct place but the chapter tooltips above the thumbnail are slightly out of sync, to the left on the left side, and to the right on the right side.

https://github.com/zydezu/ModernX/assets/20108256/1432cf1c-0b3c-4c1a-8e22-0d310eddd079

0xMOPI commented 5 months ago

Should also mention that I edited the lua locally to disable the bottom chapter markers, so only the top ones show in the video.

jiangzhenjerry commented 4 months ago

I noticed this issue too. And the degree of out of sync increases with number of chapters. So if you have a file with 20+ chapters, towards the end the chapter tooltip is totally messed up.

zydezu commented 4 months ago

Does the latest release improve this issue? (Commit: https://github.com/zydezu/ModernX/commit/eb259fb46d7a576faa7d744a65251e9299ff301a)

jiangzhenjerry commented 4 months ago

@zydezu The latest release seems to have fixed this issue. Thanks!