search

zyedidia / SFML.jl

A binding of the game and multimedia library SFML for Julia
Other
93 stars 22 forks source link

mkdir_if_necessary #3

Closed dfannius closed 9 years ago

dfannius commented 9 years ago

For some reason, when I tried to update SFML.jl this morning, I already had the directories SFML/deps/sfml/ and and SFML/deps/csfml/, so the mkdir() commands failed and the build process aborted early. This patch checks for their existence first. Perhaps it would be better to remove them and recreate them instead of skipping over the mkdir, just to make sure we have a clean slate, but at least this got past the error.

zyedidia commented 9 years ago

Yeah, this seems like a good idea. The build script should remove the directories at the end, but it didn't use to do that in 0.0.5 so when you upgraded the directories were still around and the mkdir failed. Also, if the build fails in the middle, and the directories don't get removed (because they are removed at the end) then it will crash the next time they try to build.