search

zyedidia / SFML.jl

A binding of the game and multimedia library SFML for Julia
Other
93 stars 22 forks source link

Build fails on 0.6 #37

Open dbeach24 opened 7 years ago

dbeach24 commented 7 years ago

Are there any plans to support Julia 0.6?

zyedidia commented 7 years ago

I have not been following the updates to julia so if someone else is willing I would be more than happy to merge a PR which would upgrade the deprecated and broken parts.

scls19fr commented 6 years ago

Maybe you should install femtocleaner it should help a lot to upgrade deprecated code https://github.com/JuliaComputing/FemtoCleaner.jl

https://github.com/attobot/attobot is a great bot for releasing

Domehogawa commented 6 years ago

you just have to replace every occurrence of "@windows_only" with "@static if is_windows()" in build.jl (.julia/v0.6/SFML/deps/) and in createlib.jl (.julia/v0.6/SFML/src/c/); of course you have to change "@osx_only" to "@static if is_apple()" and "@linux_only" to "@static if is_linux()"

in my case also an UndefVarError was thrown in build.jl in line 139 or so; the variable "WORD_SIZE" was not defined. It's for seperating between the 32-bit and 64-bit version, so you can write it manually instead of the variable; define the varibale yourself or find out what's the new name of it is. (i just defined it myself, although i don't think that was an good idea) those are these lines: mv("sfml-binaries/sfml/sfml-$WORD_SIZE", "sfml") mv("sfml-binaries/csfml/csfml-$WORD_SIZE", "csfml")

scls19fr commented 6 years ago

This is done on master. (@static if) Moreover WORD_SIZE have been replaced by Sys.WORD_SIZE But it's still broken