zyedidia / eget

Easily install prebuilt binaries from GitHub.
MIT License
954 stars 39 forks source link

upgrade-only failure #34

Closed leapfog closed 2 years ago

leapfog commented 2 years ago

seems using --to breaks --upgrade-only:

$ eget --upgrade-only --to=$HOME/bin zyedidia/eget

re-downloads eget (unless I already am in $HOME/bin)

dufferzafar commented 2 years ago

This is because --upgrade-only only checks for binaries in $EGET_BIN.

Can you try with EGET_BIN=$HOME/bin eget --upgrade-only zyedidia/eget ?

I personally have export EGET_BIN set, but I agree that users would expect --to to work with this as well.

Let me take a stab at this.

leapfog commented 2 years ago

You're right, after exporting EGET_BIN=$HOME/bin, there are no more re-downloads.

And yes, I would have expected that --to would work as well.

dufferzafar commented 2 years ago

@leapfog I've created a PR for this fix. 🙂