search

zyedidia / eget

Easily install prebuilt binaries from GitHub.
MIT License
954 stars 39 forks source link

Getting dist file for Archlinux while running from Fedora #50

Open esdnm opened 2 years ago

esdnm commented 2 years ago

Happened here https://github.com/contour-terminal/contour/releases/tag/v0.3.2.202

eget https://github.com/contour-terminal/contour
https://github.com/contour-terminal/contour/releases/download/v0.3.2.202/contour_0.3.2.202-archlinux_x86_64
Downloading 100% [========================================================================================================================================] (1.2/1.2 MB, 557.055 kB/s)        
Extracted `contour_0.3.2.202-archlinux_x86_64` to `contour`

Should have got the .rpm

zyedidia commented 2 years ago

Doing distro-specific auto-detection is difficult and hard to test. I'm not sure it's worth implementing, though it is annoying that eget downloads the wrong file automatically. Maybe a practical solution would be to detect if there are multiple distro-specific binaries available and let the user choose. You can always use the --asset option to select the right one as well.