Use tabs for `settings.json` as like for `bindings.json`

zyedidia / micro

A modern and intuitive terminal-based text editor

https://micro-editor.github.io

MIT License

24.42k stars 1.16k forks source link

Use tabs for `settings.json` as like for `bindings.json` #3188

Closed dustdfg closed 3 months ago

dustdfg commented 3 months ago

It is too much for separate issue or pr because I still doesn't have code so I will just write it here to grab your attention to very similar functions:

https://github.com/zyedidia/micro/blob/c64add289b396b35f790c5b20b9db9c750fb1706/internal/config/settings.go#L260-L319

I believe they could be merged into one with one additional parameter

dmaluka commented 3 months ago

Use tabs for settings.json as like for bindings.json

From what I can see, bindings.json uses spaces, not tabs. What's the matter?

dustdfg commented 3 months ago

From what I can see, bindings.json uses spaces, not tabs. What's the matter?

Consistency because bindings file use tabs

dmaluka commented 3 months ago

bindings file use tabs

Are you sure?

dustdfg commented 3 months ago

Are you sure?

No. Sorry 😅