search

zyga / django-pagination

Fork of unmaintained django-pagination - a set of utilities for creating robust pagination tools throughout a django application.
http://launchpad.net/linaro-django-pagination
BSD 3-Clause "New" or "Revised" License
39 stars 31 forks source link

Package not installable #1

Closed danfairs closed 13 years ago

danfairs commented 13 years ago

The package has an install-time dependency on the versiontools package. This means it can't be installed into a clean environment using pip, easy_install, buildout etc.

setup.py shouldn't require versiontools to be installed.

zyga commented 13 years ago

Hi.

Thanks for reporting this.

Technically this is not install-time dependency but setup-time dependency.

I know about the actual problem. I think there is a way to do it properly (since setuptools supports setup_requires) but I failed to figure out how it works. I can offer two possible solutions:

1) Figure out how to use setup_requires in a way that would trigger versiontools to be pulled in automatically 2) Stop using versiontools.

Since I wrote versiontools as well I'm actually keen on using it. If there is a strong demand _notto use versiontools at all then I could reconsider (or redesign versiontools to be needed only when releasing the tarball).

zyga commented 13 years ago

I solved this, I'll post updates soon

danfairs commented 13 years ago

On 22/06/11 20:05, zyga wrote:

I solve this, I'll post updates soon

Great to hear - thanks!

Dan Fairs | dan@fezconsulting.com | www.fezconsulting.com

zyga commented 13 years ago

I implemented solution 1. This issue is now fixed. (and available in release-2.0.2)

danfairs commented 13 years ago

I just installed it successfully - excellent stuff, thanks! And you've shown me something I didn't know about setuptools, to boot :)