zymex22 / Project-RimFactory-Revived

Project RimFactory Revived
MIT License
46 stars 34 forks source link

fix(#773): weather masks over roofed pullers #778

Closed missionz3r0 closed 5 months ago

missionz3r0 commented 5 months ago

Changes

Pics

Before

image

After

image

Sn1p3rr3c0n commented 5 months ago

Thanks for your contribution, but i opted to revet https://github.com/zymex22/Project-RimFactory-Revived/pull/777/commits/6e13400e4a6c1622cf621bf32a46ec132f325f38 instead and resolved the issue with 621de5315a70db08ffe9fa3adbe6652286a985e8. Reasoning behind that is that fillPercent has an impact on the Cover of an building and when I think about a Puller I personally don't see that having the same amount of cover as a Wall. I would expect it to be less. Without <fillPercent>1</fillPercent> the graphic issue won't occur.