search

zymlabs / nswag-fluentvalidation

Use FluentValidation rules instead of ComponentModel attributes to define swagger schema.
MIT License
59 stars 13 forks source link

Information about license #17

Closed ladamik closed 4 months ago

ladamik commented 5 months ago

We have a problem with licenses in our project. Could you add license information?

MIT

to csproj files: https://github.com/zymlabs/nswag-fluentvalidation/blob/e96dea5c6ac24d3ac6bf56842b8800fb2a1612c5/src/ZymLabs.NSwag.FluentValidation.AspNetCore/ZymLabs.NSwag.FluentValidation.AspNetCore.csproj#L7 https://github.com/zymlabs/nswag-fluentvalidation/blob/e96dea5c6ac24d3ac6bf56842b8800fb2a1612c5/src/ZymLabs.NSwag.FluentValidation/ZymLabs.NSwag.FluentValidation.csproj#L7

In our project, we check licenses by command: nuget-license -t -ji and we get errors:

ZymLabs.NSwag.FluentValidation - Cannot determine License type for url https://raw.githubusercontent.com/zymlabs/nswag-fluentvalidation/master/LICENSE

ZymLabs.NSwag.FluentValidation.AspNetCore - Cannot determine License type for url https://raw.githubusercontent.com/zymlabs/nswag-fluentvalidation/master/LICENSE.

We added packages to the "ignore" file to prevent checking licenses but it would be nice not to do it and have a possibility to check if a package has a proper license.

mbp commented 5 months ago

This can be resolved by using <PackageLicenseExpression>MIT</PackageLicenseExpression> instead of PackageLicenseUrl.

licenseUrl is deprecated according to NuGet documentation: https://learn.microsoft.com/en-us/nuget/reference/nuspec#licenseurl

geoffreytran commented 5 months ago

Yes, I'll get this updated in the next couple days.

mbp commented 4 months ago

I hope you get time to update it soon :-) Thanks!

geoffreytran commented 4 months ago

Completed!