Update Makefiles to match the new plugin build procedure

zynaddsubfx / zyn-fusion-build

Build Scripts For Zyn-Fusion

Do What The F*ck You Want To Public License

122 stars 39 forks source link

Update Makefiles to match the new plugin build procedure #104

Open AnClark opened 1 year ago

AnClark commented 1 year ago

This patch corresponds with my rewrite of plugin build procedure in ZynAddSubFX#221.

NOTICE: Currently only Makefile.linux.mk is tested.

Known issues:

Cannot cross-build via Makefile.windows.mk. Error occurs when building libuv. (Seems that it's due to header file error in MinGW-w64).

AnClark commented 1 year ago

Wait a moment, I've forgot to push my modification of VST3 output path to my ZynAddSubFX fork.

Update BJT 12:45: Done! I force-pushed my updates. Now VST3 plugin should be installed into right place.

AnClark commented 1 year ago

I encountered build error around libuv, when cross-compiling for Windows. Problem is duplicated Winsock definition in libuv's Win-API header. What about yours?

Applying this patch can help: https://github.com/AnClark/zyn-fusion-build/blob/a716bad589b0dfecd9ecdbf1310d6822a5e4127f/patch/libuv-winapi-fix-redefinition.patch (according to Msys2 package maintainers).

fundamental commented 1 year ago

I encountered build error around libuv, when cross-compiling for Windows. Problem is duplicated Winsock definition in libuv's Win-API header. What about yours?

I do not encounter this error using the ubuntu-windows dockerfile configuration included in this repo. Such an error either implies mingw is different on your system or a different libuv version is getting used.

fundamental commented 1 year ago

Good to merge conditioned on https://github.com/zynaddsubfx/zynaddsubfx/pull/221