search

zynaddsubfx / zyn-fusion-build

Build Scripts For Zyn-Fusion
Do What The F*ck You Want To Public License
122 stars 39 forks source link

Added PARALLEL=1 to build instructions #109

Closed pgervais closed 1 year ago

pgervais commented 1 year ago

Also dropped unnecessary leading tabs.

fundamental commented 1 year ago

I'd support removing the tabs, but I would avoid the -j4 in this case. Not because it's bad to run things in parallel, but because I already use a much higher -j value (specifically -j20) via the MAKEFLAGS environmental variable.

pgervais commented 1 year ago

Make sense. I'll drop the flags then and document how you can do it using MAKEFLAGS.

pgervais commented 1 year ago

I realized there is already a way to turn on parallel building in the makefiles themselves by defining a environment variable. I set this variable in the instructions, as well as in the docker build script in #110.

fundamental commented 1 year ago

Looks good to me. Merged :+1: