zynaddsubfx / zyn-fusion-build

Build Scripts For Zyn-Fusion
Do What The F*ck You Want To Public License
124 stars 40 forks source link

Master Volume not Restored under NSM #32

Closed 0mk closed 5 years ago

0mk commented 5 years ago

When running the built copy of zynaddsubfx under NSM (Non Session Manager), changes to the master volume are saved correctly when saving or closing a session. However, when opening a session, changes to the master volume are not restored as they should be.

fundamental commented 5 years ago

Looking at the NSM code all it should be doing on save is saving a .xmz file and on open it should simply load the .xmz file. Are you able to replicate the issue by loading/saving an .xmz file directly?

0mk commented 5 years ago

Thanks for looking into this issue. I can confirm that when running zyn-fusion build directly (without NSM), if I adjust the master volume and then "save master", it will save the master volume correctly. However, if I quit, then launch zyn-fusion again and "load master" from the saved file, it does NOT restore the master volume.

fundamental commented 5 years ago

Confirmed, Replicated, and fixed via https://github.com/zynaddsubfx/zynaddsubfx/commit/6e838ba43db848a0645e96d8609310b23db7ea7b