search

zynaddsubfx / zyn-fusion-build

Build Scripts For Zyn-Fusion
Do What The F*ck You Want To Public License
122 stars 39 forks source link

Update build-mingw64.sh #78

Closed Gopall closed 3 years ago

Gopall commented 3 years ago

Hello.

I was trying to build zyn-fusion for my windows computer. I used windows 10 and the MSYS2 mingw64 shell. The "build-mingw64.sh" script was out of date and didn't work. But, I made a few small changes, and now it worked for me.

In order to fix the script, I used the cross-platform building script "build-windows.rb" as a reference to figure out what to change.

I noticed that there is a another pull request which seems to overhaul the build scripts completely. However, it is large and has currently been under review for a while.

So, I think that this pull request will help in the meanwhile, since it is a small fix and easily reviewed. It will help people natively build the windows version of zyn-fusion, in the meantime.

-Thanks.

fundamental commented 3 years ago

Looks like the right modifications here. You're correct that the makefiles will be replacing the older build scripts, though one of the pre-reqs to that review was making sure that windows was building correctly such that it's easy to confirm that it works both before and after the other pull request. It's in the review queue right after a round of feedback for the moog ladder PR, which will hopefully be dealt with fairly soon since I'm starting to get more of a handle on the zyn queue again.