Issue/Suggestion for addsynth

[Lazergurka]

Okay, this was unexpected. I found the same 'issue' with the ADDsynth as with the subsynth in this post. https://github.com/zynaddsubfx/zyn-fusion-issues/issues/335

So I used the squarewave option and decreased the pulsewidth modifier to the minimum, getting a harmonically rich wave. Then I pressed the to sinewave button. Curiously, this didn't remove the highest frequencies. So from that I assume this synth also usually has 64 harmonic options, but they are hidden from the interface aswell. No clue why they wouldn't also be removed though.

Likely a good idea to check Mod-osc and pad osc aswell

[zynmuse]

The fltk interface shows 127 harmonics each with level and phase pots.

You may also note the the Adaptive Harmonic mode selector only shows 8 modes ( on both interfaces). However using automation is is possible to select all 256 modes (or maybe 127?) - which simply repeat 5xsub, 5xadd, 6xsub, 6xadd ....... etc. I have made use of the higher modes in automation - fast switching the modes randomly creates some useful effects!

[Lazergurka]

I never even spotted the scrollbar, so thank you I suppose!

[pgervais]

@Lazergurka (disclaimer: someone not very familiar with the UI speaking) I haven't been able to reproduce the issue that motivated this ticket, if you have the option, would it be possible to check with a recent version of whether the issue is still there?

[Lazergurka]

Oh hello! Yes I see I was maybe a bit unclear in my initial description the problem, so the steps were

1. select pulse
2. drag it such that the shape is just a narrow line
3. then click the to sinebutton
4. then I clicked "clear all"

curiously it seems to kinda work now but only sometimes. Also I use windows, so that may be causing issues

[pgervais]

I confirm I am able to reproduce the issue on Linux - unless I'm misunderstanding what the buttons are supposed to do. Rephrasing what @Lazergurka wrote in the above to add my comments. Steps:

• Go to Add > Oscillator
• Select "pulse" -> both waveforms turn to a step function. The right one has a little bit of noise on the high-level part.
• Click the "To Sine" button. The left waveform turns into a perfect sine, the right waveform turns into a noise square:

• Click on the "Clear all" button, which the tooltip says "clear all harmonics". My expectation is that the right waveform will turn back into a sine wave. It does happen sometimes, but we also get things like:

Clicking "clear all" and/or "to sine" more than once can improve the situation (but not always). It feels like a mix of OSC messages getting lost and floating-point roundoff errors. Meanwhile, the backend shows no errors/messages.