search

zynaddsubfx / zyn-fusion-issues

Issue Only Repo
31 stars 0 forks source link

Format graphs are empty #349

Closed zynmuse closed 2 years ago

zynmuse commented 2 years ago

When using any of the formant filters the frequency graphs show nothing. Using the old (fltk) interface they work correctly. formant

fundamental commented 2 years ago

Hm. Looks like a regression on mruby's side. d0b5096781d41e0362a6658ab870daee6ef8eb5a in mruby-zest-build should provide a workaround.

zynmuse commented 2 years ago

I don't understand how to implement the workaround. It hasn't been commited to mruby-zest-build archive and this issue has been closed.

fundamental commented 2 years ago

?

https://github.com/mruby-zest/mruby-zest-build/commit/d0b5096781d41e0362a6658ab870daee6ef8eb5a

zynmuse commented 2 years ago

Thanks. Don't know what I was looking at!

zynmuse commented 2 years ago

I see. I was looking at zynaddsubfx/zyn-fusion-build. Your changes were to mruby_zest/mruby-zest-build.

fundamental commented 2 years ago

Yep. Ideally zyn-fusion-build should be changed exceptionally rarely with all the real changes going into the backend (zynaddsubfx/zynaddsubfx) or the fairly poorly named GUI repo (mruby-zest/mruby-zest-build)

zynmuse commented 2 years ago

I'm OK with that. Still learning! The change works fine!

fundamental commented 2 years ago

I will say that there is still some quirkyness unrelated to this regression in the view. Mostly in that the fltk UI appears to assume fixed Q values, where the fusion GUI uses whatever Q value comes from the current filter, but doesn't update when the Q value is changed.