zynaddsubfx / zyn-fusion-issues

Issue Only Repo
31 stars 0 forks source link

Macro Learn on Filter Cutoff results in max setting regardless of macro mapping #399

Closed RavenRandomz closed 6 months ago

RavenRandomz commented 8 months ago
  1. Go to any filter
  2. Click learn
  3. Click on "Cutoff" in general
  4. Go to Macro Learn
  5. Click on Slot 1
  6. Play with Slider
  7. If you go back to the cutoff you bound the macro effect to, it always snaps to the max setting
  8. I have tested binding with other settings such as resonance and the binding works (when the corresponding macro effect slider is moved down, the resonance knob moves down, etc.)

OS: Ubuntu 23.0.1 Host: Ardour 8.4

RavenRandomz commented 8 months ago

Corresponding error messages


Trying to bind address '/part0/kit0/adpars/GlobalPar/GlobalFilter/basefreq' to a slot
Unknown address<BACKEND:online> '/automate/slot1.0/learning:'
Unknown address<BACKEND:online> '/automate/slot1.0/midi-cc:'
Unknown address<BACKEND:online> '/automate/slot1.0/param0/mapping/gain:'
Unknown address<BACKEND:online> '/automate/slot1.0/param0/mapping/offset:'
Unknown address<BACKEND:online> '/automate/slot1.0/param1/mapping/gain:'
Unknown address<BACKEND:online> '/automate/slot1.0/param1/mapping/offset:'
Unknown address<BACKEND:online> '/automate/slot1.0/param2/mapping/gain:'
Unknown address<BACKEND:online> '/automate/slot1.0/param2/mapping/offset:'
Unknown address<BACKEND:online> '/automate/slot1.0/param3/mapping/gain:'
Unknown address<BACKEND:online> '/automate/slot1.0/param3/mapping/offset:'
Unknown address<BACKEND:online> '/automate/slot1.0/learning:'
Unknown address<BACKEND:online> '/automate/slot1.0/midi-cc:'
Unknown address<BACKEND:online> '/automate/slot1.0/param0/mapping/gain:'
Unknown address<BACKEND:online> '/automate/slot1.0/param0/mapping/offset:'
Unknown address<BACKEND:online> '/automate/slot1.0/param1/mapping/gain:'
Unknown address<BACKEND:online> '/automate/slot1.0/param1/mapping/offset:'
Unknown address<BACKEND:online> '/automate/slot1.0/param2/mapping/gain:'
Unknown address<BACKEND:online> '/automate/slot1.0/param2/mapping/offset:'
Unknown address<BACKEND:online> '/automate/slot1.0/param3/mapping/gain:'
Unknown address<BACKEND:online> '/automate/slot1.0/param3/mapping/offset:'
Unknown address<BACKEND:online> '/automate/slot1.0/learning:'
Unknown address<BACKEND:online> '/automate/slot1.0/midi-cc:'
Unknown address<BACKEND:online> '/automate/slot1.0/param0/mapping/gain:'
Unknown address<BACKEND:online> '/automate/slot1.0/param0/mapping/offset:'
Unknown address<BACKEND:online> '/automate/slot1.0/param1/mapping/gain:'
Unknown address<BACKEND:online> '/automate/slot1.0/param1/mapping/offset:'
Unknown address<BACKEND:online> '/automate/slot1.0/param2/mapping/gain:'
Unknown address<BACKEND:online> '/automate/slot1.0/param2/mapping/offset:'
Unknown address<BACKEND:online> '/automate/slot1.0/param3/mapping/gain:'
Unknown address<BACKEND:online> '/automate/slot1.0/param3/mapping/offset:'
Unknown address<BACKEND:online> '/automate/slot1.0/learning:'
Unknown address<BACKEND:online> '/automate/slot1.0/midi-cc:'
RavenRandomz commented 8 months ago

If I leave it alone then attempt to move the slider, the whole thing crashes.

`

Unknown address<BACKEND:online> '/bankview:'
Unknown address<BACKEND:online> '/file_list_dirs:'
Unknown address<BACKEND:online> '/file_list_files:'
Unknown address<BACKEND:online> '/file_list_dirs:'
Unknown address<BACKEND:online> '/file_list_files:'
trace (most recent call last):
        [11] (unknown):0
        [10] /home/rave/Documents/github/zyn-fusion-build/src/mruby-zest-build/src/mruby-widget-lib/mrblib/script.rb:702:in tick_events
        [9] /home/rave/Documents/github/zyn-fusion-build/src/mruby-zest-build/src/mruby-widget-lib/mrblib/script.rb:415:in handle_events
        [8] /home/rave/Documents/github/zyn-fusion-build/src/mruby-zest-build/mruby/mrblib/array.rb:17:in each
        [7] /home/rave/Documents/github/zyn-fusion-build/src/mruby-zest-build/src/mruby-widget-lib/mrblib/script.rb:425:in handle_events
        [6] /home/rave/Documents/github/zyn-fusion-build/src/mruby-zest-build/src/mruby-widget-lib/mrblib/script.rb:255:in handleCursorPos
        [5] /home/rave/Documents/github/zyn-fusion-build/src/mruby-zest-build/src/mruby-widget-lib/mrblib/fcache.rb:1564:in onMouseMove
        [4] /home/rave/Documents/github/zyn-fusion-build/src/mruby-zest-build/src/mruby-widget-lib/mrblib/fcache.rb:1613:in updatePos
        [3] /home/rave/Documents/github/zyn-fusion-build/src/mruby-zest-build/src/mruby-widget-lib/mrblib/fcache.rb:1602:in updatePosAbs
        [2] /home/rave/Documents/github/zyn-fusion-build/src/mruby-zest-build/src/mruby-widget-lib/mrblib/remote.rb:55:in value=
        [1] /home/rave/Documents/github/zyn-fusion-build/src/mruby-zest-build/src/mruby-widget-lib/mrblib/remote.rb:55:in set_value
/home/rave/Documents/github/zyn-fusion-build/src/mruby-zest-build/src/mruby-widget-lib/mrblib/fcache.rb:1658:in initialize: undefined method 'valuator' (NoMethodError)
[FATAL ERROR] Mruby Is Unable To Continue
TEMPO MAP LOGIC FAILURE: [!_points.empty()] at ../libs/temporal/tempo.ccTEMPO MAP LOGIC FAILURE: [!_points.empty():2476] at ../libs/temporal/tempo.cc:

TEMPO MAP @ 2476

TEMPO MAP @ 0x58c0ad4134a0:
0x58c0ad4134a0:
... tempos...
0x31 ... tempos...
0x31 Segmentation fault (core dumped)

`

fundamental commented 6 months ago

Confirmed bug

fundamental commented 6 months ago

Looks like it was two different bugs, but both of them appear to now be resolved locally. I'll update when the fix is pushed.

fundamental commented 6 months ago

Fixes have been pushed to rtosc, zynaddsubfx, and mruby-zest-build repos which should resolve all symptoms. Thanks for documenting the bug along with an easy to replicate set of steps.