search

zyng233 / pe

0 stars 0 forks source link

Meeting did not get deleted after delete seller/buyer #9

Open zyng233 opened 1 week ago

zyng233 commented 1 week ago

Screenshot 2024-11-15 172546.png

image.png

After delete seller with phone number: 34444444, the meeting with the seller with phone number:34444444 is still there, but in UG the meeting can only include phone number of existing sellers in the client book.

nus-se-bot commented 5 days ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for testing ClientGrid.

Steps that led to this issue:

  1. User adds a buyer/seller to the client book.
  2. User adds a meeting that references this buyer/seller.
  3. User deletes the buyer/seller from the client book.
  4. Previously created meeting referencing the now deleted buyer/seller remains in the meeting book.

The bug is deemed a possible issue, and is considered response.NotInScope.

It is only a possible issue, not a confirmed one, as ClientGrid allows for meetings with properties that has been deleted intentionally as it understands that the meeting was created during a point of time where all the buyer, seller, or property involved in this meeting existed.

This behaviour is useful to users who want to use the meeting book as a means to store a record of scheduled meetings, even if the buyer/seller involved was deleted (perhaps due to the seller no longer willing to sell).

We do not want the features to be less useful than they can be.

Therefore, there is currently no feature or mechanism available to delete the meeting as well. This satisfies: 2) The user cannot attempt to use the missing feature. And thus it is response.NotInScope. Whether there should be a feature or mechanism available and its proper behavior would be debated in future iterations of the product.

Additionally, this issue is classified as severity.Low as it is unlikely to affect normal operations of the product. Appears only in very rare situations (of the user deleting the buyer/seller related to a scheduled meeting) and causes a minor inconvenience only (the user can still check through the meeting book and delete the meeting themselves, if they want to).

This is the same issue as bug #1518, which also deals with meetings not getting deleted after buyer/seller involved is deleted.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Meetings with buyers and sellers that do not exist

Description

If i have modified json file and deleted all data for clients, meetings do not get resetted as well. Resulting in meeting to still exist despite having no corresponding buyer and seller

Steps to reproduce

  1. Create random meetings
  2. Delete clientbook.json
  3. Check list for clients and meetings

Expected behaviour

Meetings should also be deleted as there is no clients present that are link

Actual behaviour

image.png

image.png

[original: nus-cs2103-AY2425S1/pe-interim#2093] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for testing ClientGrid.

Steps that led to this issue:

  1. User adds a buyer/seller to the client book.
  2. User adds a meeting that references this buyer/seller.
  3. User deletes the buyer/seller from the client book.
  4. Previously created meeting referencing the now deleted buyer/seller remains in the meeting book.

The bug is deemed a possible issue, and is considered response.NotInScope.

It is only a possible issue, not a confirmed one, as ClientGrid allows for meetings with properties that has been deleted intentionally as it understands that the meeting was created during a point of time where all the buyer, seller, or property involved in this meeting existed.

This behaviour is useful to users who want to use the meeting book as a means to store a record of scheduled meetings, even if the buyer/seller involved was deleted (perhaps due to the seller no longer willing to sell).

We do not want the features to be less useful than they can be.

Therefore, there is currently no feature or mechanism available to delete the meeting as well. This satisfies: 2) The user cannot attempt to use the missing feature. And thus it is response.NotInScope. Whether there should be a feature or mechanism available and its proper behavior would be debated in future iterations of the product.

We think the severity and type of this bug here is correct (Low, FunctionalityBug). This is the same issue as bug #3701, which also deals with meetings not getting deleted after buyer/seller involved is deleted.

Reason is given as such: This issue is classified as severity.Low as it is unlikely to affect normal operations of the product. Appears only in very rare situations (of the user deleting the buyer/seller related to a scheduled meeting) and causes a minor inconvenience only (the user can still check through the meeting book and delete the meeting themselves, if they want to).

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]