zynthian / zynthian-issue-tracking

Centralized Issue Tracking for Zynthian Project
https://github.com/orgs/zynthian/projects/1
11 stars 3 forks source link

ORAM - DragonFly Plate Reverb plug-in goes silent #1092

Open nzimas opened 3 weeks ago

nzimas commented 3 weeks ago

I don't know if this issue is specific to my particular V4 hardware or if it is software related.

A few minutes after a session is opened, the audio signal that goes through the right channel in the main line out falls silent.

After rebooting the machine, the problem is gone, but then it resurfaces again.

The fact that the audio signal is restored after rebooting makes me suspect of a software issue, rather than a physical one.

The headphones output is not affected.

I am running the latest beta (as of 2024.06.16).

nzimas commented 3 weeks ago

I have isolated the root cause.

The DragonFly Plate Reverb plug-in crashes a few minutes after the snapshot session is initiated. After removing the effect, the sound is coming out of both channels again.

riban-bw commented 3 weeks ago

I have been running the DragonFly Plate Reverb for many mniutes without any issue. Please provide full details of your hardware and software configuration. A screenshot of the webconf dashboard will be helpful and a copy of the snapshot that you are using. (Be aware that if you use the "Report Issue" button in webconf then you will automatically provide more info during the initial issue report.)

nzimas commented 3 weeks ago

Here are the Webconf dashboard screenshot and a copy of the relevant snapshot.

014-nz02.zss.zip

Screenshot 2024-06-17 at 20 18 13
riban-bw commented 2 weeks ago

If the plugin crashes then I would expect all audio to be lost, not just one channel. What evidence do you have that the plugin has crashed? Is it no longer running? Is there any log indication of failure?

nzimas commented 2 weeks ago

I've concluded that the issue is related to the plugin because when I remove it from the FX chain, the stereo audio signal is restored.

On Wed, 26 Jun 2024, 10:02 riban-bw, @.***> wrote:

If the plugin crashes then I would expect all audio to be lost, not just one channel. What evidence do you have that the plugin has crashed? Is it no longer running? Is there any log indication of failure?

— Reply to this email directly, view it on GitHub https://github.com/zynthian/zynthian-issue-tracking/issues/1092#issuecomment-2190962533, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVCFLSSB36PDQDT3FL5LOTZJJROTAVCNFSM6AAAAABJMZ4XTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJQHE3DENJTGM . You are receiving this because you authored the thread.Message ID: @.***>

riban-bw commented 2 weeks ago

Okay - so the plugin does not crash but making changes to the chain restores output. It sounds more like a routing issue. I am trying to reproduce the issue but my V4 is currently not routing audio from LinuxSampler (which looks like an unrelated issue).

riban-bw commented 2 weeks ago

I have been running this snapshot for several minutes on a V4 with headphones enabled. I have sequences playing to trigger notes on the two MIDI channels (6 & 8) to trigger sound from the three instrument chains. Audio continues to be passed to both main outputs.

Is there any more information you can give about what is being done to trigger the issue? What devices are connected? Are they being played? Is there any other interaction with the Zynthian?

nzimas commented 2 weeks ago

Not much else to add, really. The OP-Z is sending MIDI notes to the synths and that's pretty much it.

Perhaps the issue occurs only on my unit, although it stands to reason that the removal of the dragonfly plug-in from the FX chain results in full restoration of the audio signal.

I guess I'll have to choose another reverb plugin :)

On Wed, 26 Jun 2024, 10:30 riban-bw, @.***> wrote:

I have been running this snapshot for several minutes on a V4 with headphones enabled. I have sequences playing to trigger notes on the two MIDI channels (6 & 8) to trigger sound from the three instrument chains. Audio continues to be passed to both main outputs.

Is there any more information you can give about what is being done to trigger the issue? What devices are connected? Are they being played? Is there any other interaction with the Zynthian?

— Reply to this email directly, view it on GitHub https://github.com/zynthian/zynthian-issue-tracking/issues/1092#issuecomment-2191012665, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVCFLQYGVYK5AEM2GIHUNDZJJU2RAVCNFSM6AAAAABJMZ4XTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRGAYTENRWGU . You are receiving this because you authored the thread.Message ID: @.***>

riban-bw commented 2 weeks ago

Is the OP-Z connected via 5-pin DIN MIDI or USB? Are there any other devices connected and how? Does this fault occur reliable, every time the snapshot is loaded? How long does it take to occur? Does it happen with a different plugin instead of Dragonfly?

riban-bw commented 2 weeks ago

I have reproduced the issue (although I see loss of audio on both channels on main and headphones). It does seem to be Dragonfly Plate Reverb causing the problem. If I manually (e.g. in Patchage) remove the audio routing from Dragonfly to system playback (main output) then manually route other audio to system playback then I hear audio. As soon as I route the output from Dranonfly to system playback the output goes silent. (It is possible that the ouput is being driven at sub/super-sonic frequency which may cause it to fail. (It may be full level d.c.)

If I remove all "Wet" signal from the Dragonfly and leave only "Dry" then it works so it is within the processing of the reverb - not the whole plugin.

This should be reported upstream - after checking versions.

[Edit] There is d.c. splat on speakers when Dragonfly (suffering this issue) is connected / disconnected to main output.

[Edit] The version of Dragonfly Reverb used in Zynthian is 3.2.8 (Debian 12 Bookworm) which is tagged in GitHub as being released (or having last git commit) on 2022-12-28 with commit d87f5e4. There have been a further 2 releases (3.2.10 2023-23-04). We should test the latest version before we can report upstream.

[Edit] Changing the preset in the Dragonfly Plate REverb GUI (via VNC) restores audio. (We do not present these presets in Zynthian for some reason - they must not be presented in the ttl files.)

riban-bw commented 2 weeks ago

I have compiled the plugin from source and am now testing...

...and it goes wrong there too. I have manually routed the output of the reverb plugin back to an mixer input (not subsequently routed to main mix) and monitored its DPM and see that they go full scale deflection during this fault, showing full level super/subsonic audio. This needs to be reported upstream.

jofemodo commented 2 weeks ago

@riban, we have LV2 presets for Dragonfly Plate (Room and Hall too!) in Oram. This presets should be available from zynthian-ui too. I just tested and they are not. Let me do my research.

jofemodo commented 2 weeks ago

For some reason the preset cache was not regenerated. I've applied a patch to fix it. Simply update and test the presets