search

zynthian / zynthian-issue-tracking

Centralized Issue Tracking for Zynthian Project
https://github.com/orgs/zynthian/projects/1
11 stars 3 forks source link

Download LV2 user preset does not encode bank name #1100

Open riban-bw opened 4 months ago

riban-bw commented 4 months ago

Describe the issue

When downloading a LV2 preset, the whole bank is downloaded as manifest.ttl and individualy preset.ttl files. These files are packaged in a zip archive with the plugin name and bank name encoded in the title. When a user preset is downloaded, only the plugin name is used, resulting in the same zip filename being used for every download and no obvious indication of bank name.

To Reproduce

Steps to reproduce the behavior:

  1. Add a LV2 plugin, e.g. AIDA-X
  2. Bold press to access Chain Options and select the plugin
  3. Select "Save Preset" and add a new bank and preset
  4. In webconf, go to LIBRARY->Presets & Soundfonts
  5. Select the plugin, e.g. AIDA-X
  6. Select the bank and preset the download

    Expected behaviour

    Download has bank name, e.g. AIDA-X_MyBank.presets.lv2.zip

    Actual behaviour

    Download does not have bank name, e.g. AIDA-X.presets.lv2.zip

    Additional context

    If you do this for a LV2 plugin with factory presets like synthv1 you get the expected behaviour, e.g. synthv1_392Synthv1Patches.presets.lv2.zip.

    Configuration

    Hardware

    Raspberry Pi 4 Model B Rev 1.5
Audio: V5 ADAC
Display: MIPI DSI 800x480 (inverted)
Wiring: V5
I2C: MCP23017@0x20, MCP23017@0x21
Profile: v5

    System

    Debian GNU/Linux 12 (bookworm)
Build Date: 2024-02-01
Memory: 33% (1255M/3792M)
SD Card: 93% (26G/29G)
Temperature: 48.7ºC
Overclock: Maximum

    MIDI & UI

    Tuning: 440 Hz
Master Channel: 16
Preload Presets: Off
ZS3 (SubSnapShots): On
Power Save: 10 minutes
Audio Levels on Snapshots: On

    Software

    zyncoder: oram (628f3fb) 
zynthian-ui: oram (371f6df)
zynthian-sys: oram (4461148)
zynthian-data: oram (e222e11)
zynthian-webconf: oram (f31699f)
riban-bw commented 4 months ago

This is due to how presets are saved in zyngui. It is not a webconf issue.