zynthian / zynthian-issue-tracking

Centralized Issue Tracking for Zynthian Project
https://github.com/orgs/zynthian/projects/1
11 stars 3 forks source link

Pattern editor parameter editor not working for touch #1163

Open riban-bw opened 1 month ago

riban-bw commented 1 month ago

Describe the issue

With onscreen buttons enabled, bold pressing an event in the pattern editor shows the parameter editor and onscreen buttons. The left two buttons show +/- 0.1 but actually adjust the length by +/- 1. Other parameters like velocity, offset, etc. do not work at all.

To Reproduce

Steps to reproduce the behavior:

  1. Enable onscreen buttons
  2. Go to pattern edito
  3. Add a not event
  4. Bold press the event
  5. For each parameter, press +/- buttons

    Expected behaviour

    Parameter value changes.

    Actual behaviour

    Only duration changes and not by amount shown on +/- button.

    Additional context

    It can be challenging to access parameter editor if you move the pointer/finger during the bold press.

Configuration

Hardware

Raspberry Pi 4 Model B Rev 1.4
Audio: ZynADAC
Display: ZynScreen 3.5 (v1)
Wiring: MCP23017_ZynScreen
I2C: MCP23017@0x20, MCP23017@0x21, ADS1115@0x48

System

Debian GNU/Linux 12 (bookworm)
Build Date: 2024-03-01
Memory: 57% (1060M/1846M)
SD Card: 26% (14G/57G)
Temperature: 53.0ºC
Overclock: Medium

MIDI & UI

Tuning: 440 Hz
Master Channel: Off
Preload Presets: On
ZS3 (SubSnapShots): On
Power Save: 60 minutes
Audio Levels on Snapshots: On

Software

zyncoder: oram (62626a8) 
zynthian-ui: oram (66ceddc)
zynthian-sys: oram (5affa51)
zynthian-data: oram (e222e11)
zynthian-webconf: oram (0327ac4)