Cannot access high numbered layers in the mixer view

[riban-bw]

Describe the bug If there are more layers / channels / chains than can be displayed within the mixer view, navigating to higher indices fails.

To Reproduce Steps to reproduce the behavior:

1. Add multiple layers until there are more than can be displayed within mixer view
2. Use SELECT encoder to move highlight to right

Expected behaviour Faders scroll left and right to allow access to all chains.

Actual behaviour Faders stop scrolling when reaching right hand end of screen then jump 2 back when scrolling left.

Setup:

• HARDWARE Raspberry Pi 3 Model B Plus Rev 1.3 Soundcard: HifiBerry DAC+ ADC PRO Display: ZynScreen 3.5 (v1) Wiring: MCP23017_ZynScreen GPIO Expander: MCP23017
• SYSTEM Raspbian GNU/Linux 10 (buster) Build Date: 2021-09-23 Memory: 58% (542M/923M) SD Card: 49% (14G/29G) Temperature: 59.1ºC
• MIDI Profile: default.sh Fine Tuning: 440 Hz Master Channel: off Single Active Channel: on ZS3 SubSnapShots: off
• SOFTWARE zyncoder: testing (1609f8d) zynthian-ui: testing (789ba16) zynthian-sys: testing (587dd76) zynthian-data: testing (076a23d) zynthian-webconf: testing (0de7a5e)

Additional context This is due to misunderstanding of various indices, i.e.

• Layer / channel / chain index
• Offset within all layers of first visible channel
• Position within visible channels
• Position within all chanels
• etc.

[riban-bw]

I am in the process of resolving this. I plan to use the layer as the identifier / object associated with each fader strip rather than the MIDI channel which was previously done and caused this confusion. I hope to have if fixed soon.

[riban-bw]

I have submitted pull request https://github.com/zynthian/zynthian-ui/pull/421 that fixes this. Awaiting validation and merge.

[jofemodo]

It works pretty well now. Closing!