Zynseq thows error when scrolling through keymaps

[riban-bw]

Describe the bug Selecting a keymap for a pattern in step sequencer can give an error in the log.

To Reproduce Steps to reproduce the behavior:

1. Open pattern editor
2. From menu select "Scale"
3. Rotate SELECT encoder quickly

Expected behaviour Each keymap is shown.

Actual behaviour Fast scrolling triggers error:

Apr 27 03:35:59 zynthian startx[4410]: ERROR:zynthian_gui.refresh_status: list index out of range
Apr 27 03:35:59 zynthian startx[4410]: Traceback (most recent call last):
Apr 27 03:35:59 zynthian startx[4410]:   File "./zynthian_gui.py", line 1880, in refresh_status
Apr 27 03:35:59 zynthian startx[4410]:     self.screens[self.current_screen].refresh_status(self.status_info)
Apr 27 03:35:59 zynthian startx[4410]:   File "/home/pi/zynthian-ui/zyngui/zynthian_gui_stepsequencer.py", line 583, in refresh_status
Apr 27 03:35:59 zynthian startx[4410]:     self.child.refresh_status()
Apr 27 03:35:59 zynthian startx[4410]:   File "/home/pi/zynthian-ui/zyngui/zynthian_gui_patterneditor.py", line 968, in refresh_status
Apr 27 03:35:59 zynthian startx[4410]:     self.draw_grid()
Apr 27 03:35:59 zynthian startx[4410]:   File "/home/pi/zynthian-ui/zyngui/zynthian_gui_patterneditor.py", line 685, in draw_grid
Apr 27 03:35:59 zynthian startx[4410]:     self.draw_row(index)
Apr 27 03:35:59 zynthian startx[4410]:   File "/home/pi/zynthian-ui/zyngui/zynthian_gui_patterneditor.py", line 593, in draw_row
Apr 27 03:35:59 zynthian startx[4410]:     self.draw_cell(step, row)
Apr 27 03:35:59 zynthian startx[4410]:   File "/home/pi/zynthian-ui/zyngui/zynthian_gui_patterneditor.py", line 617, in draw_cell
Apr 27 03:35:59 zynthian startx[4410]:     note = self.keymap[row + self.keymap_offset]["note"]
Apr 27 03:35:59 zynthian startx[4410]: IndexError: list index out of range

Setup:

• HARDWARE Raspberry Pi 3 Model B Plus Rev 1.3 Audio: HifiBerry DAC+ ADC PRO Display: ZynScreen 3.5 (v1) Wiring: MCP23017_ZynScreen I2C: MCP23017@0x20 Profile: z2_v1
• SYSTEM Raspbian GNU/Linux 10 (buster) Build Date: 2021-09-23 Memory: 54% (500M/923M) SD Card: 60% (16G/29G) Temperature: 69.3ºC Overclock: Disabled
• MIDI Profile: default.sh Tuning: 440 Hz Receive Mode: Stage (Omni On) ZS3 Sub-SnapShots: Off MIDI to Output: On Master Channel: off
• SOFTWARE zyncoder: testing (e236925) zynthian-ui: masterfx (727a4f6) zynthian-sys: testing (a5e66e4) zynthian-data: testing (10e1f9f) zynthian-webconf: testing (729cc9b)

Additional context Almost certainly poor handling of encoder acceleration. This has changed recently so probably needs an extra check.

[jofemodo]

Is this fixed?

[riban-bw]

Fixed by recent fixes and optimisations of menu.