search

zynthian / zynthian-issue-tracking

Centralized Issue Tracking for Zynthian Project
https://github.com/orgs/zynthian/projects/1
11 stars 3 forks source link

Navigation issues #648

Closed riban-bw closed 2 years ago

riban-bw commented 2 years ago

Describe the bug The following button operations trigger unexpected actions:

Setup:

Additional context These observations are based on testing and documentation creation for the pending 2205 release. There are some changes of behaviour from previous versions to improve consistent behaviour.

jofemodo commented 2 years ago

I comment one by one. Fixes have been done on masterfx branch.

Short press LAYER from preset list goes to Main Menu but should do nothing

Fixed!

Short press LEARN/SHOT from preset list kinda toggles Favourites but not well - is this required?

Yes. This is the original and prefered way. The favorites pseudobank was added for "touchies" but i don't like too much and i would prefer to remove it when we figure a better way (perhaps removing touch interface? };-DD ) BTW, i've improved the way it works and now it's more consistent.

Short press LAYER from bank list goes to Main Menu but should do nothing

Fixed!

Short press LEARN/SHOT from bank list kinda toggles Favourites but not well - is this required?

Already explained. It should work better now.

Short press BACK from ZynPad goes back to previous screen, e.g. menu. Maybe this isn't desirable?

What about going to mixer? But it should be consistent with Audio & MIDI recorder, Audio Levels, etc. Done!

Short press LAYER from ZynPad shows menu - should this be bold LAYER?

From my POV:

Short press BACK from Audio Levels does nothing - should return to previous menu

For being consistent, it should back to mixer. Done!

Short press LEARN/SHOT from Audio Levels switches to layer MIDI-Learn

Fixed! Now it triggers Audio Levels control MIDI learn.

Short press LAYER from selector, e.g. Engine selection shows Main Menu but leaves self in screen history - should do nothing

Fixed!

riban-bw commented 2 years ago

Cool - well done!

Thanks for fixing favourites toggle. There is a small issue with it. If you press SNAPSHOT to show Favourites then press BACK to navigate to bank list, " Favorites " is not highlighted.

(As much fun as it was trying every combination of navigation / button press, it would be good if there was an automated test method for this!!!)

Also if you toggle Favourites on and off then subsequent navigation from control screen skips the preset list, i.e.

Also, replacing an audio effect in a synth chain shows the list of Engines with first effect plugin (engine) shown. It would be optimal to select the engine that is being replaced. I notices when I was stepping through engines and each replace put me back at the start of the list. (I guess that isn't navigation but...)

jofemodo commented 2 years ago

Press LEARN/SHOT to hide favourites (you end up back in contrl screen) Not in my zynthian. You should go back to presets and so it does in my zynthians. Please update to latest testing (masterfx is already merged).

Except by this (you shouldn't back to control after clicking "learn" to hide favorites), this is the expected behaviour . When you click back from presets you go to banks, one click more and yo return to control. No other way of reaching banks.

I already fixed the highlighting detail ;-)

jofemodo commented 2 years ago

Can we close this? ;-)

riban-bw commented 2 years ago

He he,,, almost! I think the encoder switch navigation is almost right:

There are some touch navigations that need resolving...

jofemodo commented 2 years ago

Done "Replacing engine/FX should highlight current one".

riban-bw commented 2 years ago

Recent changes to encoder interface and other changes requires retesting of all navigation from all controllers including:

riban-bw commented 2 years ago

Review of hardware encoder control:

Review of touch & mouse interface:

No issues found.

riban-bw commented 2 years ago

Fixed most of the encoder navigation issues. There are some global actions triggered by long press which I have not changed. I suggest we live with them for a while and garner user feedback.

QWERTY keyboard control is currently broken. I suggest we move the zyncoder polling to the zyngui class and get it to trigger on_zyncoder events within views. This allows keyboard mapping to be assigned to on_zyncoder events as required.

Testing of CUIA and OSC should be deferred until decision on zyncoder handling as these interact similarly.