zynthian / zynthian-issue-tracking

Centralized Issue Tracking for Zynthian Project
https://github.com/orgs/zynthian/projects/1
11 stars 3 forks source link

Cannot see which controller is selected for X-Y control #671

Open riban-bw opened 2 years ago

riban-bw commented 2 years ago

Describe the bug The value arc is coloured to indicate a controller is enabled for X-Y control. If a controller is at its minimum value then there is no arc and the indication is not visible.

To Reproduce Steps to reproduce the behavior:

  1. Add an engine
  2. Go to the engine's control screen
  3. Set a control to its minimum value
  4. Simultaneously bold press on the control and another control

Expected behaviour Both controls indicate they are enabled for XY control.

Actual behaviour The control set to minimum value has no indication it is selected.

Setup:

Additional context I did add a fix for this but it was disablef for some reason. Instead of, or as well as colouring the arc, the title and/or the value can be coloured. These are always displayed and hence the indication is always visible. An alternative would be to colour the background of the controller. This may be more obvious and perhaps more accessible.

riban-bw commented 2 months ago

Issue #1179 suggests a workflow that may resolve this. It uses menus to access the X & Y controller assignment seperately then a menu to access the X-Y view. This would mean we don't need to colour controllers because their config is done via menu. We may want to indicate that we are in the X-Y control selection mode but that would be the subject of #1179.