zynthian / zynthian-issue-tracking

Centralized Issue Tracking for Zynthian Project
https://github.com/orgs/zynthian/projects/1
11 stars 3 forks source link

MIDI channel view keeps changing when playing MIDI file #675

Closed riban-bw closed 1 year ago

riban-bw commented 2 years ago

Describe the bug Playing a MIDI file will cause the MIDI channel selection view to change selection.

To Reproduce Steps to reproduce the behaviour:

  1. Start playback of a MIDI file using MIDI Recorder view (enable loop to keep it going throughout test)
  2. From main menu, New Synth Chain
  3. Select any engine, e.g. FluidSynth
  4. Move highlight in MIDI Channel view

Expected behaviour MIDI channel responds to user navigation.

Actual behaviour MIDI channel changes selection based on MIDI messages received from player, making it pretty much impossible to use.

Setup:

Additional context It looks like there is some kind of helper function zynthian_gui_midi_chan::midi_chan_activity to select MIDI channel from incoming message but this gives poor UX when MIDI channel is changing rapidly, e.g. SMF playing.

riban-bw commented 1 year ago

I believe @wyleu requested this feature. When in MIDI channel list, playing a note on an external controller will jump to that channel in the list. It is a helper to assist with assigning controlelrs to engines / chains but it has a nasty side effect that if other MIDI notes are playing, e.g. from a sequencer, SMF, etc. then the list will jump about like a cat on a hot tin roof. The side effect is significant, sometimes disabling use of the device because navigation is completely broken. I suggest we disable this helper feature (which is undocumented and probably little used) until a better implementation can be applied (triggered by a well though out and structured feature request).