zynthian / zynthian-issue-tracking

Centralized Issue Tracking for Zynthian Project
https://github.com/orgs/zynthian/projects/1
11 stars 3 forks source link

Default MIDI learn values are used when a snapshot has cleared them #701

Open riban-bw opened 2 years ago

riban-bw commented 2 years ago

Describe the bug When loading a snapshot that includes controllers with MIDI learn CC overriden with empty CC, the original default CC are assigned.

To Reproduce Steps to reproduce the behaviour:

  1. Add Fluidsynth to a chain
  2. Enable MIDI learn for volume
  3. Cancel MIDI learn to clear the volume's learned CC
  4. Save as snapshot
  5. Restore snapshot

Expected behaviour Volume MIDI learn is empty.

Actual behaviour Volume MIDI learn is reset to CC7.

Setup:

riban-bw commented 2 years ago

Maybe perform midi learn clean before restoring snapshot learn parameters.