zyonse / homebridge-dreo

Apple HomeKit integration for Dreo Smart Devices
https://www.npmjs.com/package/homebridge-dreo
Apache License 2.0
38 stars 19 forks source link

Adding Temp Sensor and Different modes as well as silent button #18

Closed danielkorkin closed 7 months ago

danielkorkin commented 1 year ago

Adding support for the temperature sensor as a temp sensor and different modes such as sleep, auto etc and support for the silent button make everything a button including oscillating

alvst commented 1 year ago

Temperature, assuming it's returned by the api, should be an easy add. HomeKit, surprisingly, does not support different modes so that's not possible in a way done well.

alvst commented 1 year ago

Based on my review of the HA code, temperature does seem to be returned by the api. I'll take a look and see if I can get it added to this one via a PR.

zyonse commented 1 year ago

The websocket connection reports the temperature sensor state so that should be feasible to implement. I agree with @alvst that the modes would be difficult to implement in a clean way. Though I could add a toggle to the config to just permanently mute the fan if that's something people would be interested in.

zyonse commented 1 year ago

The reason I didn't initially implement the temp sensor is because I've found it to be inaccurate.

alvst commented 1 year ago

Yes that makes sense. I find the temp sensor in my dreo to be 2-3 degrees, sometimes more, higher than my other temperature sensors say.

danielkorkin commented 1 year ago

maybe adjust it down by 2-3 degrees or asking the user in home bridge setup optionally the difference in temp then adding it later?

alvst commented 12 months ago

Took me a while because I forgot about this but I've created a pull request with the temperature sensor added as well as the offset and ability to show/hide the temperatures sensors. for simplicity, if you have multiple fans, you can't show/hide individual temperature sensors, but you can always hide those within the home app.

danielkorkin commented 11 months ago

Thank You!

RadDip commented 11 months ago

Version 3.2 with Temp sensor is off significantly in homekit compared to what it is in the Dreo app. So my Deep app is reading 68 degrees F and Homekit is reading 154 degrees F

dfinstein commented 11 months ago

Version 3.2 with Temp sensor is off significantly in homekit compared to what it is in the Dreo app. So my Deep app is reading 68 degrees F and Homekit is reading 154 degrees F

I’m having a similar issue. My Dreo fan temp sensor in Homekit is displaying 100 degrees Fahrenheit higher than the actual reading in the Dreo app. This is new behavior in 3.2.

alvst commented 11 months ago

The conversion between Celsius and Fahrenheit is off. I submitted a fix yesterday waiting on approval.