search

zyonse / homebridge-dreo

Apple HomeKit integration for Dreo Smart Devices
https://www.npmjs.com/package/homebridge-dreo
Apache License 2.0
29 stars 17 forks source link

Added Temperature Sensor #19

Closed alvst closed 8 months ago

alvst commented 9 months ago

Per issue #18, I have added a temperature sensor. This is optional, and there is also an option to provide a set temperature offset since the Dreo Temperature sensors are pretty inaccurate.

zyonse commented 9 months ago

Thanks for the pull request! I’m out of town but I’ll look at this when I get home.

RadDip commented 8 months ago

Just an FYI. Version 3.1.0 is not showing up in Hoobs plugin library

RadDip commented 8 months ago

Temperature reading is off significantly in homekit from what the fan app is reading. Ie. Fan app is reading 68 degrees F. and homekit app is reading 154 degrees F.

alvst commented 8 months ago

Temperature reading is off significantly in homekit from what the fan app is reading. Ie. Fan app is reading 68 degrees F. and homekit app is reading 154 degrees F.

Yea I noticed this too. Fix is simple though. Just need to return the value found in Celsius instead. 1 line fix I'll submit. Not sure how I missed this.

zyonse commented 8 months ago

I wonder if there's a way to make the fan report the temperature in Celsius.

alvst commented 8 months ago

I looked into the app and in the API response object, neither say which units the temp is returned in. My guess is it probably automatically chooses based on the region the fan is in/the server the fan is configured to.

mganjoo commented 8 months ago

The app does have a temperature unit switch in fan settings (you have to click on the picture of the fan to find it on iOS; it was confusing).

But it doesn’t look like switching it to Celsius changed anything - the API response still seemed to be in Fahrenheit.

alvst commented 8 months ago

The app does have a temperature unit switch in fan settings (you have to click on the picture of the fan to find it on iOS; it was confusing).

But it doesn’t look like switching it to Celsius changed anything - the API response still seemed to be in Fahrenheit.

Yea I found this too about an hour ago and after switching it, the api still seems to be returning the data in Fahrenheit.

mganjoo commented 8 months ago

Created a PR to convert from F -> C: #23