Ability to hide individual temperature sensors

zyonse / homebridge-dreo

Apple HomeKit integration for Dreo Smart Devices

https://www.npmjs.com/package/homebridge-dreo

Apache License 2.0

29 stars 17 forks source link

Ability to hide individual temperature sensors #26

Closed alvst closed 6 months ago

alvst commented 7 months ago

I never intended to limit the ability to hide temperature sensors for all devices only but I was didn't have time to add this functionality earlier. Now you can hide the temperature sensor for individual fans!

alvst commented 7 months ago

Just saw this. Yes will get this done.

alvst commented 6 months ago

README has been updated with a new section called Features which now says: Display the temperature sensor detected within your devices (for supported devices, check your devices capabilities). Because the Dreo devices temperature sensors are not entirely accurate, you can also set a specific temperature offset for your devices.

zyonse commented 5 months ago

After some more testing, I need you to make a few changes to make this more user friendly,

Keep the checkbox to hide all (fan) temperature sensors
If the checkbox is unchecked, the config ui should show a drop-down menu letting you add/remove devices that you'd like to hide
Show a description in the config ui explaining that you can enter a device id in order to hide its individual temperature sensor

alvst commented 5 months ago

Based on my discussions within the Homebridge Discord when I developed this change, this is not possible since devices are automatically added when you log-into your account. Is this incorrect? Can you direct me to some documentation for this then I'd be happy to add this.

alvst commented 5 months ago

Specifically, since the Device ID isn't inputted into the settings screen, you can't map over the devices to create unique instances. The way I've seen other platform plugins get around this is to just log the Device ID's into the console upon installation of the plugin and NOT initiate the devices until the user adds them into the plugin settings. This then allows you to add individual settings for each.

zyonse commented 5 months ago

Apologies, what I meant is that I want a way for the user to be able to add multiple Device IDs from the config-ui. Ideally it should look something like this (homebridge-tplink-smarthome):

I would also like the "hide all temperature sensors" button from the current release to remain in place.

Feel free to open a new pull request once those changes are implemented. Sorry again for the inconvenience and thank you for your contributions to the project.

alvst commented 5 months ago

Ah I see, yes I can try to do that. I thought I already did but so there maybe a reason why I didn't but I can't remember. I'll let you know it may have just been in a separate branch that didn't work or I got side tracked or something.