search

zyra / ionic-image-loader

Ionic 2+ Component that loads images in a background thread and caches them for later use
MIT License
436 stars 137 forks source link

Ionic 4 - plans for compatibility #209

Open cezarykluczynski opened 5 years ago

cezarykluczynski commented 5 years ago

Are there any plans to make Ionic Image Loader compatible with Ionic 4?

Currently it can't be used with Ionic 4 because of error:

ERROR in node_modules/ionic-image-loader/dist/providers/image-loader.d.ts(3,26): error TS2307: Cannot find module 'ionic-angular'.

newtonmunene99 commented 5 years ago

Running into the same problem. Tried implementing it,got stuck along the way.

mateusduraes commented 5 years ago

+1

crebuh commented 5 years ago

+1

ruudboon commented 5 years ago

Would be great

madoBaker commented 5 years ago

In the works, please be patient :)

ruudboon commented 5 years ago

Sweet! Thnx @madoBaker

ruudboon commented 5 years ago

Is the v4 branch the working branch for this? Can we help with some pull requests?

madoBaker commented 5 years ago

Is the v4 branch the working branch for this? Can we help with some pull requests?

Correct, and PR's are greatly appreciated!

mtshare commented 5 years ago

+1 Still not working on Ionic 4 ERROR in node_modules/ionic-image-loader/dist/providers/image-loader.d.ts(3,26): error TS2307: Cannot find module 'ionic-angular'.

simbig commented 5 years ago

for me it worked using the beta version: npm i -S ionic-image-loader@beta

tbthiago commented 5 years ago

+1 Still not working need it urgently!! :(

jokabuyasina commented 5 years ago

still not working on ionic 4

abePdIta commented 5 years ago

Using ionic-image-loader@7.0.0-beta.2 and @ionic-native/ionic-webview@5.12.0 now and it works.

Fieel commented 4 years ago

+1 Still not natively working on ionic 4 and we're halfway through 2020

I can confirm @abePdIta solution works tho, I installed both packages and edited my app.module.ts as such:

import { WebView } from '@ionic-native/ionic-webview/ngx'; import { IonicImageLoader } from 'ionic-image-loader';

IonicImageLoader.forRoot() in the imports array, WebView in the providers array then also add IonicImageLoader in your page's module imports array.

madmacc commented 3 years ago

The build works with @abePdIta's solution and the beta version in Ionic 5 with Capacitor but it fails on an Android device with the error:

Uncaught TypeError: Cannot read property 'id' of undefined
    at registerNgModuleType (/vendor-es2015.js:81976)
    at /vendor-es2015.js:81987
    at Array.forEach (<anonymous>)
    at registerNgModuleType (/vendor-es2015.js:81987)
    at new NgModuleFactory$1 (/vendor-es2015.js:82084)
    at compileNgModuleFactory__POST_R3__ (/vendor-es2015.js:85628)
    at PlatformRef.bootstrapModule (/vendor-es2015.js:85866)
    at Module../src/main.ts (/main-es2015.js:3464)
    at __webpack_require__ (/runtime-es2015.js:85)
    at Object.0 (/main-es2015.js:3477)