zyrouge / node-genius-lyrics

Simple lyrics fetcher that uses Genius. Also has official API implementations.
https://genius-lyrics.js.org
MIT License
61 stars 12 forks source link

switch to node-html-parser from cheerio #46

Closed twlite closed 10 months ago

twlite commented 1 year ago

tldr; Switch to node-html-parser for better performance.

Genius Lyrics is used by @discord-player/extractor and parsing lyrics usually seems to block the thread (which seems to be caused by cheerio). node-html-parser states that Per the design, it intends to parse massive HTML files in lowest price, thus the performance is the top priority.. Benchmark results show that node-html-parser is very fast compared to cheerio.

zyrouge commented 10 months ago

Done!