search

zyrouge / symphony

🎵 Lightweight, elegant music player for Android 9+.
https://zyrouge.github.io/symphony/
GNU Affero General Public License v3.0
1.27k stars 81 forks source link

[Bug] Add support for all ID3 lyric frames #646

Open Mitezuss opened 1 week ago

Mitezuss commented 1 week ago

Description

from where get the text embed on the mp3 ?

Steps to Reproduce

tried multiple field but not working

Expected Behavior

wanna see the lyrics

Screenshots

No response

Additional Context

No response

Device

No response

OS

Android 13

Version

Latest

Contribution Guidelines

Mitezuss commented 1 week ago

@zyrouge

should be UNSYNCEDLYRICS

but after "Support synced and .lrc lyrics."

the lyric embed can not be read (is ignored, just use the file .lrc on latest version)

can implement a check for .lrc and if not exist use the unsyc lyric embeded ?

zyrouge commented 1 week ago

https://github.com/zyrouge/symphony/blob/2b6b63a8efe21cf8367a3173a42a6f10d88c2dcc/app/src/main/java/io/github/zyrouge/metaphony/metadata/id3v2/ID3v2Metadata.kt#L23 Support for lyrics and lyrics-xxx is implemented. USLT or LST are not supported.

zyrouge commented 1 week ago

@zyrouge

should be

but after "Support synced and .lrc lyrics."

the lyric embed can not be read (is ignored, just use the file .lrc on latest version)

can implement a check for .lrc and if not exist use the unsyc lyric embeded ?

There is just too many tags used this. Lrc files always get the priority if they exist.

Mitezuss commented 1 week ago

Support for lyrics

the "LYRICS" field is ignored too

Lrc files always get the priority

yes, but the fields inside the mp3 is ignore anyway (if the file .lrc dnt exist)

(sry my bad english)

zyrouge commented 1 week ago

Support for lyrics

the "LYRICS" field is ignored too

Lrc files always get the priority

yes, but the fields inside the mp3 is ignore anyway (if the file .lrc dnt exist)

(sry my bad english)

As I mentioned lyrics and lyrics-xxx should work since I did test them.

Mitezuss commented 1 week ago

As I mentioned lyrics and lyrics-xxx should work since I did test them.

can share the mp3 to test ? not working for me =/ (on latest version, but on OLD version (without lrc feature) the field is detected)

like i said, after the version with "Support synced and .lrc lyrics." the field is ignored (Although there is no file .lrc)

zyrouge commented 1 week ago

Sure. The lyrics tag will not be used if lrc file is detected.

Mitezuss commented 1 week ago

The lyrics tag will not be used if lrc file is detected.

yes, i know that...

@zyrouge ok, after some test:

on FLAC file the "LYRICS" field is detected but not on MP3

for MP3 need detect/read the "UNSYNCEDLYRICS" field (checked with other app)