search

zyrouge / symphony

🎵 Lightweight, elegant music player for Android 9+.
https://zyrouge.github.io/symphony/
GNU Affero General Public License v3.0
1.27k stars 81 forks source link

[Feature] Unintended behavior: Redundand update checking on repository installs #667

Closed sevonj closed 5 days ago

sevonj commented 6 days ago

Description

At initial launch the app asked me about checking for updates. It was a bit confusing as I got it from F-Droid, which should be responsible for that.

I dived into the source code to see what's actually going on here, and it seems to be intended for direct apk downloads only. This is redundant and slightly confusing when installed from an app repository, like play store or f-droid.

Solution

On builds distributed through app repositories:

Alternatives

No response

Additional Context

No response

Contribution Guidelines

zyrouge commented 5 days ago

Please read about this decision. (https://github.com/zyrouge/symphony/issues/119)

sevonj commented 5 days ago

The point of this issue isn't permissions and trust, but rather janky user experience. That part can be fixed without separate builds, by matching the install source.

zyrouge commented 5 days ago

The point of this issue isn't permissions and trust, but rather janky user experience. That part can be fixed without separate builds, by matching the install source.

How exactly would you find the install source?

sevonj commented 5 days ago

The function is called getInstallerPackageName getInstallSourceInfo

I can investigate exact implementation further.

zyrouge commented 5 days ago

The function is called ~getInstallerPackageName~ getInstallSourceInfo

I can investigate exact implementation further.

And what if the user wants to be notified if there are any updates? I still think it's better to stay as is. Just disable the update notification and call it a day.

sevonj commented 5 days ago

The user would get notifications or auto-updates from play store or f-droid.

Self-check is on by default, but disabled if the install source is an explicit match to one we know to handle updates.