search

zytedata / zyte-autoextract

Python clients for Zyte AutoExtract API
BSD 3-Clause "New" or "Revised" License
39 stars 7 forks source link

Retry of Downloader error: internal #34

Closed ivanprado closed 3 years ago

ivanprado commented 3 years ago

In many cases, this is how banning issues are flagged.

codecov-io commented 3 years ago

Codecov Report

Merging #34 (c7114b0) into master (37b8fe7) will increase coverage by 0.06%. The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   66.60%   66.66%   +0.06%     
==========================================
  Files          13       14       +1     
  Lines         500      501       +1     
  Branches       65       65              
==========================================
+ Hits          333      334       +1     
  Misses        163      163              
  Partials        4        4
Impacted Files Coverage Δ
autoextract/aio/client.py 47.14% <ø> (ø)
autoextract/aio/errors.py 97.36% <ø> (ø)
autoextract/aio/retry.py 53.33% <ø> (ø)
autoextract/request.py 100.00% <ø> (ø)
autoextract/sync.py 84.21% <ø> (ø)
autoextract/__main__.py 22.97% <50.00%> (ø)
autoextract/__version__.py 100.00% <100.00%> (ø)
autoextract/constants.py 100.00% <100.00%> (ø)
autoextract/utils.py 100.00% <100.00%> (ø)
autoextract/__init__.py 100.00% <0.00%> (ø)
... and 1 more
philip-healy commented 3 years ago

Ivan wait!

This behaviour has changed with the recent backend release.

I would revalidate before applying this patch.

From now on all banning errors should be reported as "Proxy error: banned" or "Proxy error: internal_error", and you have both of those cases covered already.

ivanprado commented 3 years ago

Thank you @philip-healy for the feedback and investigation :+1: . It seems that the renaming of errors is still not in production, but it will. So closing this PR as it makes no sense.