search

zytedata / zyte-common-items

Contains the common item definitions used in Zyte.
BSD 3-Clause "New" or "Revised" License
9 stars 6 forks source link

Add the customAttributes field to items and pages. #100

Closed wRAR closed 1 month ago

wRAR commented 2 months ago

Not sure if this should go into a base class (e.g. Item) as we currently don't have any fields in it.

Gallaecio commented 2 months ago

I do wonder if we should consider deprecating _unknown_fields_dict and instead mapping those into customAttributes. Although things could be problematic if an item has both, e.g. {"foo": "bar", "customAttributes": {"foo": "baz"}}.